Add query client status command
#3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
force-pushed
the
romac/query-client-status
branch
from
3d601cb
to
ec5e67f
Compare
9 tasks
romac
requested review from
seanchen1991 and
ljoss17
and removed request for
seanchen1991
ljoss17
approved these changes
Mar 24, 2023
| @@ -258,6 +259,104 @@ impl Runnable for QueryClientHeaderCmd { | |||
| } | |||
| } | |||
|
|
|||
| /// Query client status command | |||
| #[derive(Clone, Command, Debug, Parser, PartialEq, Eq)] | |||
| pub struct QueryClientStatusCmd { | |||
There was a problem hiding this comment.
Everything seems good to me. Just missing the 3 unit tests for the new CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3041
Closes: #3124
Description
TODO
Follow-up issue at #3191 for the following items:
ForeignClientcode so that:PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.